feat: Adding features for sorting space points in r in (phi, z) grid #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: @LuisFelipeCoelho |
Codecov Report
@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
- Coverage 47.50% 47.48% -0.02%
==========================================
Files 376 376
Lines 19810 19816 +6
Branches 9305 9308 +3
==========================================
Hits 9410 9410
- Misses 4010 4016 +6
Partials 6390 6390
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Good from my side |
noemina
force-pushed
the
config-radial-sorting
branch
from
171438a
to
32d5ee4
Compare
We (ATLAS seeder) have use cases profiting of both options implemented in this PR. |
robertlangenberg
approved these changes
May 30, 2022
Merged
10 tasks
Scott-James-Hurley
pushed a commit
to Scott-James-Hurley/acts_profiling
that referenced
this pull request
Jun 6, 2022
…cts-project#1267) * adding features for sorting sp in r * re-trigger CI * re-trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two features for sorting space points in radius for each (phi, z) grid bin.
binSizeR, is added to theSeedFinderConfigin order to allow the user to configure the bin size in R. By default it stays 1 mm.forceRadialSorting, is added to theSeedFinderConfigin order to allow the user to force the space point in each (phi, z) bin to be sorted in radius. This is false by default.