Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable phi values in grid construction #1275

Conversation

noemina
Copy link
Contributor

@noemina noemina commented May 30, 2022

Self-explanatory title. See changes for additional information.

@LuisFelipeCoelho

@noemina noemina added this to the next milestone May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1275 (4f23b5c) into main (239ece3) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 4f23b5c differs from pull request most recent head 6a89dc0. Consider uploading reports for the commit 6a89dc0 to get more accurate results

@@           Coverage Diff           @@
##             main    #1275   +/-   ##
=======================================
  Coverage   47.48%   47.48%           
=======================================
  Files         376      376           
  Lines       19816    19816           
  Branches     9308     9308           
=======================================
  Hits         9410     9410           
  Misses       4016     4016           
  Partials     6390     6390           
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SpacePointGrid.hpp 0.00% <ø> (ø)
Core/include/Acts/Seeding/SpacePointGrid.ipp 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the changes

@noemina noemina force-pushed the config-phi-axis-range-space-point-grid branch from f39c06d to ae7891b Compare June 3, 2022 09:37
@noemina
Copy link
Contributor Author

noemina commented Jun 7, 2022

Do you see any problem with this PR or can be merged?

@robertlangenberg robertlangenberg enabled auto-merge (squash) June 7, 2022 12:24
@robertlangenberg robertlangenberg added Feature Development to integrate a new feature automerge labels Jun 7, 2022
@robertlangenberg robertlangenberg merged commit bd55ecb into acts-project:main Jun 7, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.2.0 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants