fix: Change edm4hep track state writing to write params #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
approved these changes
Jul 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1311 +/- ##
=======================================
Coverage 47.42% 47.42%
=======================================
Files 375 375
Lines 19788 19788
Branches 9287 9287
=======================================
Hits 9385 9385
Misses 4021 4021
Partials 6382 6382 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation tries to use the projector on the track parameters. This changes that.
Also, we need to consider what we actually write here. In principle we can do perigees relative to the surface center.