refactor: Improve ActsPythonBindings tracing #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 10, 2022 19:11
…xamples. Show Config and Interval too.
Codecov Report
@@ Coverage Diff @@
## main #1425 +/- ##
=======================================
Coverage 47.80% 47.80%
=======================================
Files 380 380
Lines 20168 20168
Branches 9382 9382
=======================================
Hits 9641 9641
Misses 4083 4083
Partials 6444 6444 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
added
the
backport develop/v19.x
acts-project-service
pushed a commit
that referenced
this pull request
Aug 12, 2022
* Improves how `acts.examples.dump_args_calls()` finds the `acts.ActsPythonBindings` functions to wrap with `dump_args()`. This should now find them all. * I've used it with `full_chain_itk.py`, `full_chain_odd.py`, and `vertex_fitting.py` * For brevity, `dump_args()` doesn't print `Config()` calls with no arguments. * fix for `addSeeding(truthSeedRanges=None)` (unrelated, except the above helped debug) (cherry picked from commit b945729)
paulgessinger
pushed a commit
that referenced
this pull request
Aug 12, 2022
…op/v19.x] (#1426) refactor: Improve ActsPythonBindings tracing (#1425) * Improves how `acts.examples.dump_args_calls()` finds the `acts.ActsPythonBindings` functions to wrap with `dump_args()`. This should now find them all. * I've used it with `full_chain_itk.py`, `full_chain_odd.py`, and `vertex_fitting.py` * For brevity, `dump_args()` doesn't print `Config()` calls with no arguments. * fix for `addSeeding(truthSeedRanges=None)` (unrelated, except the above helped debug) (cherry picked from commit b945729) Co-authored-by: Tim Adye <T.J.Adye@rl.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acts.examples.dump_args_calls()finds theacts.ActsPythonBindingsfunctions to wrap withdump_args(). This should now find them all.full_chain_itk.py,full_chain_odd.py, andvertex_fitting.pydump_args()doesn't printConfig()calls with no arguments.addSeeding(truthSeedRanges=None)(unrelated, except the above helped debug)