Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: consistent naming for simhits #1451

Merged
merged 2 commits into from
Aug 22, 2022
Merged

refactor: consistent naming for simhits #1451

merged 2 commits into from
Aug 22, 2022

Conversation

andiwand
Copy link
Contributor

rename SimulatedHits vs SimHits

@codecov
Copy link

codecov bot commented Aug 19, 2022 •
edited

Codecov Report

Merging #1451 (95e19ed) into main (2171277) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1451   +/-   ##
=======================================
  Coverage   48.59%   48.59%           
=======================================
  Files         380      380           
  Lines       20589    20589           
  Branches     9431     9431           
=======================================
  Hits        10005    10005           
  Misses       4097     4097           
  Partials     6487     6487

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

paulgessinger
paulgessinger approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulgessinger paulgessinger added this to the next milestone Aug 22, 2022
@kodiakhq kodiakhq bot merged commit 50ad783 into acts-project:main Aug 22, 2022
@andiwand andiwand deleted the refactor-consistency-simhits branch August 22, 2022 07:22
@andiwand andiwand mentioned this pull request Aug 22, 2022
Closed
@paulgessinger paulgessinger added the backport develop/v19.x Backport this PR to the v19.x series label Aug 22, 2022
acts-project-service pushed a commit that referenced this pull request Aug 22, 2022
@andiwand @github-actions
refactor: consistent naming for simhits (#1451)
74d875b 
rename `SimulatedHits` vs `SimHits`

(cherry picked from commit 50ad783)
@acts-project-service acts-project-service mentioned this pull request Aug 22, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Aug 22, 2022
@acts-project-service
refactor: consistent naming for simhits [backport #1451 to develop/v1…
2d6a24e 
…9.x] (#1455)

Backport 50ad783 from #1451.
---
rename `SimulatedHits` vs `SimHits`
@paulgessinger paulgessinger modified the milestones: next, v20.1.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
backport develop/v19.x Backport this PR to the v19.x series
Projects
None yet
Milestone
v20.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andiwand @paulgessinger