feat: Update RootVertexPerformanceWriter to work with track finding #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1460 +/- ##
=======================================
Coverage 48.60% 48.60%
=======================================
Files 380 380
Lines 20595 20595
Branches 9433 9433
=======================================
Hits 10010 10010
Misses 4097 4097
Partials 6488 6488 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
approved these changes
Aug 23, 2022
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
|
Ok I fixed one source of inconsistency resulting in output changes, and then checked that the remaining output changes we see here only come from the newly added branches. I'll let the CI run and update the hashes, and then I think this is good to go. |
andiwand
approved these changes
Aug 31, 2022
andiwand
approved these changes
Sep 1, 2022
paulgessinger
added
automerge
backport develop/v19.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
RootVertexPerformanceWriterassumed a 1:1 correspondence between truth particles and reconstructed tracks. This PR implements hit based truth matching to enable this to run.