fix: Set s_binningValues as const #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1485 +/- ##
=======================================
Coverage 48.60% 48.60%
=======================================
Files 380 380
Lines 20595 20595
Branches 9433 9433
=======================================
Hits 10010 10010
Misses 4097 4097
Partials 6488 6488
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CarloVarni
changed the title
andiwand
reviewed
Sep 2, 2022
There was a problem hiding this comment.
thanks! looks good to me. I will leave it up to @paulgessinger to approve
paulgessinger
approved these changes
Sep 2, 2022
paulgessinger
added
automerge
backport develop/v19.x
|
CI bridge refused because @CarloVarni is not on the allowlist yet. I'm merging this manually. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-develop/v19.x develop/v19.x
# Navigate to the new working tree
cd .worktrees/backport-develop/v19.x
# Create a new branch
git switch --create backport-1485-to-develop/v19.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b172918b0cb02d910faabc534e8db2069c27e78a
# Push it to GitHub
git push --set-upstream origin backport-1485-to-develop/v19.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-develop/v19.xThen, create a pull request where the |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Sep 22, 2022
Setting `s_binningValues` as `const` as well. The Atlas Thread-check is complaining about this since it suspect this may be not thread safe.
paulgessinger
added a commit
that referenced
this pull request
Sep 22, 2022
#1547) Setting `s_binningValues` as `const` as well. The Atlas Thread-check is complaining about this since it suspect this may be not thread safe. Co-authored-by: Carlo Varni <75478407+CarloVarni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
s_binningValuesasconstas well. The Atlas Thread-check is complaining about this since it suspect this may be not thread safe.