Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clang-tidy warnings #1560

Merged

Conversation

paulgessinger
Copy link
Member

#1541 introduced a few clang-tidy warnings that weren't caught. This PR fixes those

\acts-project#1541 introduced a few clang-tidy warnings that weren't caught. This PR
fixes those
@paulgessinger paulgessinger added this to the next milestone Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #1560 (2406ee3) into main (8fbf7de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1560   +/-   ##
=======================================
  Coverage   48.47%   48.47%           
=======================================
  Files         381      381           
  Lines       20699    20699           
  Branches     9503     9503           
=======================================
  Hits        10034    10034           
  Misses       4112     4112           
  Partials     6553     6553           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand andiwand self-assigned this Sep 28, 2022
@kodiakhq kodiakhq bot merged commit 8bc896e into acts-project:main Sep 28, 2022
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Oct 3, 2022
acts-project#1541 introduced a few clang-tidy warnings that weren't caught. This PR fixes those
kodiakhq bot pushed a commit that referenced this pull request Oct 3, 2022
…#1563)

Backport 8fbf7de from #1541
---
The Optuna and Orion optimization algorithms are used to auto-tune some parameters of seeding algorithm and performance has been checked on the CKF algorithm.

Also includes #1560
@paulgessinger paulgessinger modified the milestones: next, v20.3.0 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants