refactor: Restructure track fitting functions #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Improvement
added 2 commits
October 24, 2022 19:24
Examples/Algorithms/TrackFitting/include/ActsExamples/TrackFitting/TrackFittingAlgorithm.hpp
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1617 +/- ##
=======================================
Coverage 48.66% 48.66%
=======================================
Files 381 381
Lines 20776 20776
Branches 9517 9517
=======================================
Hits 10110 10110
Misses 4095 4095
Partials 6571 6571 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 2 commits
October 25, 2022 09:19
AJPfleger
reviewed
Oct 25, 2022
Examples/Algorithms/TrackFitting/include/ActsExamples/TrackFitting/TrackFittingAlgorithm.hpp
Outdated
Show resolved
Hide resolved
📊 Physics performance monitoring for febbd44Full report VertexingIVF seededIVF truth smearedIVF truth estimatedCKFseededtruth smearedtruth estimatedTruth trackingTruth tracking |
andiwand
approved these changes
Oct 25, 2022
…ting/TrackFittingAlgorithm.hpp Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
andiwand
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does
TrackFittingAlgorithm, so no static member functions anymore, rather free functions. I think that is better, because it is possible to add new fitters without touching the algorithm file etc...std::optional<std::vector<const Surface *>>in the function arguments. I think this reduces code duplication etc.Should not increase build memory consumption, since everything stays separated as before in the different compilation units.
Note:
Also I think the direct track fitting is broken anyways in this algorithm, but that should be addressed seperately. A small problem I think i fixed in this PR, but in general this only works properly if there are no material surfaces that are non-measurement surfaces (because only these are added to the surface sequence). Maybe we should discuss this somehow. We do not test direct fitting right now, right?