feat: skip unnecessary iterations in seed filter if SPs are sorted by curvature #1672
Conversation
LuisFelipeCoelho
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1672 +/- ##
==========================================
- Coverage 48.98% 48.96% -0.02%
==========================================
Files 397 397
Lines 21497 21505 +8
Branches 9801 9802 +1
==========================================
Hits 10530 10530
- Misses 4171 4179 +8
Partials 6796 6796
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 18d74bf
Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeeding ❌Seeding seeded❌ Seeding truth_smeared Seeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
…acts into filter-skip-sp
There was a problem hiding this comment.
The change looks alright.
Just had few suggestions that could improve understanding the code by others.
I would like to make a general comment. As of now the function has 200+ lines of quite involved logic.
It may help to make it easier to follow if it could be partitioned in a few smaller functions with meaningful names.
|
I tested this with 500 ttbar events with PU=200 in standalone and it seems to be slightly faster FYI: @paulgessinger |
… curvature (acts-project#1672) This is a small change to avoid unnecessary iteration in the seed filter based on the sorting of the outer SPs. The seeding performance is the same but slightly faster.
This is a small change to avoid unnecessary iteration in the seed filter based on the sorting of the outer SPs.
The seeding performance is the same but slightly faster.