build: Add -Wfloat-conversion to clang warnings

[benjaminhuth]

this seems at least in clang catch implicit float-to-bool conversion.

[andiwand]

lets see if that catches #1673 too

[paulgessinger]

This is a good idea. Just needs the code fixes now 😄

[benjaminhuth]

I would propose a Fix-a-thon for this :D

[paulgessinger]

I fixed all the conversion warnings with static_cast or more clever replacements.

[benjaminhuth]

Would it be okay to merge this with the warning only enabled for clang @paulgessinger? Then we have at least these changes in for now.

[github-actions]

📊 Physics performance monitoring for c9cb63d

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[paulgessinger]

I guess the only argument against would be that it's maybe unexpected to see a warning in the CI and then not locally. But to some extent this is already the case depending on which compiler you use.

[codecov]

Codecov Report

Merging #1676 (c9cb63d) into main (70dc953) will decrease coverage by 0.05%.
The diff coverage is 70.73%.

@@            Coverage Diff             @@
##             main    #1676      +/-   ##
==========================================
- Coverage   49.83%   49.77%   -0.06%     
==========================================
  Files         406      406              
  Lines       22532    22521      -11     
  Branches    10280    10286       +6     
==========================================
- Hits        11228    11210      -18     
- Misses       4131     4132       +1     
- Partials     7173     7179       +6     

Impacted Files	Coverage Δ
Core/include/Acts/Seeding/BinnedSPGroup.ipp	0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SpacePointGrid.ipp	0.00% <0.00%> (ø)
...de/Acts/TrackFitting/detail/KLMixtureReduction.hpp	56.25% <ø> (ø)
Core/src/Material/VolumeMaterialMapper.cpp	8.52% <0.00%> (ø)
Core/src/Material/MaterialGridHelper.cpp	62.30% <70.83%> (-7.35%)	⬇️
Core/include/Acts/Geometry/SurfaceArrayCreator.hpp	42.85% <100.00%> (ø)
Core/include/Acts/Material/MaterialComposition.hpp	81.08% <100.00%> (ø)
Core/include/Acts/Surfaces/detail/FacesHelper.hpp	55.55% <100.00%> (ø)
...re/include/Acts/Surfaces/detail/VerticesHelper.hpp	54.54% <100.00%> (+1.42%)	⬆️
Core/include/Acts/Utilities/BinningData.hpp	69.23% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kodiakhq]

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.