Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CSV track param reader #1678

Merged
merged 11 commits into from
Nov 30, 2022
Merged

feat: CSV track param reader #1678

merged 11 commits into from
Nov 30, 2022

Conversation

andiwand
Copy link
Contributor

adds a CSV track parameter reader to the examples

@andiwand andiwand added the Component - Examples Affects the Examples module label Nov 16, 2022
@andiwand andiwand added this to the next milestone Nov 16, 2022
@andiwand andiwand added the 🚧 WIP Work-in-progress label Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022 •
edited

Codecov Report

Merging #1678 (b08ce41) into main (4a2d047) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1678   +/-   ##
=======================================
  Coverage   49.02%   49.02%           
=======================================
  Files         397      397           
  Lines       21558    21558           
  Branches     9817     9817           
=======================================
  Hits        10568    10568           
  Misses       4181     4181           
  Partials     6809     6809

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Nov 16, 2022 •
edited

📊 Physics performance monitoring for b08ce41

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand andiwand removed the 🚧 WIP Work-in-progress label Nov 17, 2022
AJPfleger
AJPfleger reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just marginally a part of this PR, but is there I reason, why we have the header file Examples/Io/Csv/src/CsvOutputData.hpp in the src-directory instead of include?

Also I think we need to update the (c)-dates in the files, we have modified.

@andiwand
Copy link
Contributor Author

andiwand commented Nov 21, 2022 •
edited

... is there I reason, why we have the header file Examples/Io/Csv/src/CsvOutputData.hpp in the src-directory instead of include?

I can only guess but it looks like the csv structs are not used anywhere outside and are therefore more like an implementation detail.

@AJPfleger
Copy link
Contributor

Ups, I see, I was very vague. With the year-update I meant 2019-2022

@AJPfleger
Copy link
Contributor

... is there I reason, why we have the header file Examples/Io/Csv/src/CsvOutputData.hpp in the src-directory instead of include?

I can only guess but it looks like the csv structs are not used anywhere outside and are therefore more like an implementation detail.

@paulgessinger ?

@asalzburger asalzburger self-requested a review November 29, 2022 15:29
asalzburger
asalzburger approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge.

@kodiakhq kodiakhq bot merged commit 3701035 into acts-project:main Nov 30, 2022
@andiwand andiwand deleted the feature-example-csv-trackparam-reader branch November 30, 2022 14:49
@andiwand andiwand mentioned this pull request Dec 8, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Dec 13, 2022
@andiwand
feat: examples CSV track param writer (#1717)
56f460a 
adding a track param writer

similar to #1678
pbutti pushed a commit to pbutti/acts that referenced this pull request Dec 13, 2022
@andiwand @pbutti
feat: CSV track param reader (acts-project#1678)
2e96ab2 
adds a CSV track parameter reader to the examples
pbutti pushed a commit to pbutti/acts that referenced this pull request Dec 13, 2022
@andiwand @pbutti
feat: examples CSV track param writer (acts-project#1717)
f92a5ee 
adding a track param writer

similar to acts-project#1678
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
@andiwand
feat: CSV track param reader (acts-project#1678)
d6e653e 
adds a CSV track parameter reader to the examples
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
@andiwand
feat: examples CSV track param writer (acts-project#1717)
09e09fa 
adding a track param writer

similar to acts-project#1678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJPfleger AJPfleger AJPfleger left review comments

@asalzburger asalzburger asalzburger approved these changes

Assignees

@asalzburger asalzburger

Labels
Component - Examples Affects the Examples module
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andiwand @AJPfleger @asalzburger @paulgessinger