fix: comment_template bugs for seeding monitoring #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
added
Bug
Codecov Report
@@ Coverage Diff @@
## main #1683 +/- ##
=======================================
Coverage 48.96% 48.96%
=======================================
Files 397 397
Lines 21505 21505
Branches 9802 9802
=======================================
Hits 10530 10530
Misses 4179 4179
Partials 6796 6796 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 022a70c
Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeeding ❌Seeding seeded❌ Seeding truth_smeared Seeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
approved these changes
Nov 23, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
This PR removes the nonexistent truth_smeared seeding plots from comment_template.md Sorry, this is something I forgot to remove in PR #1683 😅
pbutti
pushed a commit
to pbutti/acts
that referenced
this pull request
Dec 13, 2022
This PR fixes some bugs from acts-project#1665 seeding performance monitoring
pbutti
pushed a commit
to pbutti/acts
that referenced
this pull request
Dec 13, 2022
…s-project#1694) This PR removes the nonexistent truth_smeared seeding plots from comment_template.md Sorry, this is something I forgot to remove in PR acts-project#1683 😅
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
This PR fixes some bugs from acts-project#1665 seeding performance monitoring
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
…s-project#1694) This PR removes the nonexistent truth_smeared seeding plots from comment_template.md Sorry, this is something I forgot to remove in PR acts-project#1683 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some bugs from #1665 seeding performance monitoring