Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add check in TrackFitterPerformanceWriter #1686

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

benjaminhuth
Copy link
Member

Check if we have a valid trajectory before trying to access it and emit a warning.

@benjaminhuth benjaminhuth added Improvement Changes to an existing feature Component - Examples Affects the Examples module labels Nov 22, 2022
@benjaminhuth benjaminhuth added this to the next milestone Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1686 (a9cd01b) into main (75d8e2b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1686   +/-   ##
=======================================
  Coverage   48.96%   48.96%           
=======================================
  Files         397      397           
  Lines       21505    21505           
  Branches     9802     9802           
=======================================
  Hits        10530    10530           
  Misses       4179     4179           
  Partials     6796     6796           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

📊 Physics performance monitoring for a9cd01b

🟥 ERROR The result has missing elements!
This is likely a physmon job failure

Full report
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, , ❌ orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding ❌

Seeding seeded

❌ Seeding truth_smeared

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit 3f799e9 into acts-project:main Nov 22, 2022
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
Check if we have a valid trajectory before trying to access it and emit a warning.
@benjaminhuth benjaminhuth deleted the fix/fitter-perf-writer-check branch February 22, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants