fix: Protection against v == 0 in template_switch #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1707 +/- ##
==========================================
+ Coverage 49.21% 49.27% +0.06%
==========================================
Files 398 398
Lines 21790 21763 -27
Branches 9899 9874 -25
==========================================
Hits 10724 10724
+ Misses 4203 4174 -29
- Partials 6863 6865 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
approved these changes
Dec 9, 2022
📊 Physics performance monitoring for 125c751Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
pbutti
pushed a commit
to pbutti/acts
that referenced
this pull request
Dec 13, 2022
Add a check in `template_switch` methods in case `v == 0` (i.e. no measurements) and add corresponding error message
CarloVarni
added a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
Add a check in `template_switch` methods in case `v == 0` (i.e. no measurements) and add corresponding error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check in
template_switchmethods in casev == 0(i.e. no measurements) and add corresponding error message