Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GX2F: more iterations in unitTest #1711

Merged
merged 15 commits into from
Dec 5, 2022
Merged

Conversation

AJPfleger
Copy link
Contributor

Add more iterations in the ZeroFieldNoSurfaceForward-test, since during testing some errors did not occur with only 2 iterations.

@AJPfleger AJPfleger added this to the next milestone Dec 5, 2022
@AJPfleger AJPfleger added the Improvement Changes to an existing feature label Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1711 (bb3b455) into main (1d4f320) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1711   +/-   ##
=======================================
  Coverage   49.04%   49.04%           
=======================================
  Files         397      397           
  Lines       21578    21578           
  Branches     9823     9823           
=======================================
  Hits        10583    10583           
  Misses       4186     4186           
  Partials     6809     6809           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

📊 Physics performance monitoring for bb3b455

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit e7b72fc into acts-project:main Dec 5, 2022
@github-actions github-actions bot removed the automerge label Dec 5, 2022
pbutti pushed a commit to pbutti/acts that referenced this pull request Dec 13, 2022
Add more iterations in the `ZeroFieldNoSurfaceForward`-test, since during testing some errors did not occur with only 2 iterations.
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
Add more iterations in the `ZeroFieldNoSurfaceForward`-test, since during testing some errors did not occur with only 2 iterations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants