fix: Make Range1D a proper half-open interval
#1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
Bug
|
Unit test(s) seem to check for this (ostensibly) incorrect check. Can you fix it/them? |
|
This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs. |
stephenswat
force-pushed
the
fix/range1d_degeneracy
branch
from
635a8d4
to
8d24e37
Compare
stephenswat
changed the title
Range1DRange1D a proper half-open interval
Previously, the `Range1D` class checked for degeneracy as if it were a closed interval, but it is designed to be half-open. This commit changes the logic to represent this.
stephenswat
force-pushed
the
fix/range1d_degeneracy
branch
from
8d24e37
to
ac14348
Compare
|
This should now be ready to go. |
andiwand
approved these changes
Jan 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #1715 +/- ##
=======================================
Coverage 49.80% 49.80%
=======================================
Files 406 406
Lines 22565 22565
Branches 10305 10305
=======================================
Hits 11239 11239
Misses 4138 4138
Partials 7188 7188
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for ac14348Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
Range1Dclass checked for degeneracy as if it were a closed interval, but it is designed to be half-open. This commit changes the logic to represent this.