Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: transpose vectors in AMVF logging #1719

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Dec 8, 2022

reduce AMVF logging lines by transposing vectors before printing

@andiwand andiwand added this to the next milestone Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

📊 Physics performance monitoring for d2abe59

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1719 (d2abe59) into main (e2ed9fb) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1719   +/-   ##
=======================================
  Coverage   49.28%   49.28%           
=======================================
  Files         398      398           
  Lines       21787    21787           
  Branches     9884     9884           
=======================================
  Hits        10737    10737           
  Misses       4201     4201           
  Partials     6849     6849           
Impacted Files Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 41.52% <ø> (ø)
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 46.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andiwand andiwand changed the title refactor: AMVF logging refactor: transpose vectors in AMVF logging Dec 8, 2022
@kodiakhq kodiakhq bot merged commit b5c32d0 into acts-project:main Dec 8, 2022
@github-actions github-actions bot removed the automerge label Dec 8, 2022
pbutti pushed a commit to pbutti/acts that referenced this pull request Dec 13, 2022
reduce AMVF logging lines by transposing vectors before printing
@paulgessinger paulgessinger modified the milestones: next, v22.0.0 Dec 21, 2022
CarloVarni pushed a commit to CarloVarni/acts that referenced this pull request Dec 22, 2022
reduce AMVF logging lines by transposing vectors before printing
@andiwand andiwand deleted the refactor-amvf-logging branch January 24, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants