refactor!: Fitters use loggers more consistently #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgessinger
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1727 +/- ##
==========================================
- Coverage 49.28% 49.14% -0.14%
==========================================
Files 395 395
Lines 21810 21800 -10
Branches 9929 9953 +24
==========================================
- Hits 10748 10713 -35
- Misses 4179 4187 +8
- Partials 6883 6900 +17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 141f18cFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
I would propose overriding the coverage check here. |
tboldagh
approved these changes
Dec 15, 2022
You're right that it technically has side-effects. The original decision predates me ( 😉 ) but I think the |
andiwand
approved these changes
Dec 16, 2022
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
First follow up to acts-project#1724 (includes that PR as well), which switches the KF, CKF, GSF and GX2F to use `Logger` directly, getting rid of the `LoggerWrapper`. This uses the new clone mechanism to create child loggers for the actor. To remove the logger instance from the propagation options, I had to change all the actors and aborters, to take the logger as an explicit argument. I changed the ActionList and AbortList to just forward any arguments that are passed into the call operator, as that should be more flexible. Since this makes the sort-of-concept-style call signature checks very complex, I tentatively removed those as well now. I think it's fine to drop these, they don't provide too much value here, and the action and abort list are in need of an actual reimplementation anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First follow up to #1724 (includes that PR as well), which switches the KF, CKF, GSF and GX2F to use
Loggerdirectly, getting rid of theLoggerWrapper. This uses the new clone mechanism to create child loggers for the actor.To remove the logger instance from the propagation options, I had to change all the actors and aborters, to take the logger as an explicit argument. I changed the ActionList and AbortList to just forward any arguments that are passed into the call operator, as that should be more flexible. Since this makes the sort-of-concept-style call signature checks very complex, I tentatively removed those as well now. I think it's fine to drop these, they don't provide too much value here, and the action and abort list are in need of an actual reimplementation anyway.