fix: in cylinder volume helper #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Physics performance monitoring for 4d30150Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #1750 +/- ##
==========================================
- Coverage 49.28% 49.28% -0.01%
==========================================
Files 395 395
Lines 21806 21810 +4
Branches 9925 9929 +4
==========================================
Hits 10748 10748
Misses 4179 4179
- Partials 6879 6883 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
asalzburger
requested review from
andiwand and
paulgessinger
and removed request for
andiwand
andiwand
approved these changes
Dec 15, 2022
CarloVarni
pushed a commit
to CarloVarni/acts
that referenced
this pull request
Dec 22, 2022
This baffles me that this bug was undiscovered for such a long time. When glueing container to container, the inter glue radius has to be re-evaluated between the volumes in case of r-binning, but that was not the case in the `CylinderVolumeHelper`. This cherry-pick should fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This baffles me that this bug was undiscovered for such a long time.
When glueing container to container, the inter glue radius has to be re-evaluated between the volumes in case of r-binning, but that was not the case in the
CylinderVolumeHelper.This cherry-pick should fix this.