refactor!: MTJ calibrated size via dedicated method #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to facilitate backends where the calibrated size is calculated on demand, and can't easily be returned by reference.
|
Can you have a look @tboldagh? |
paulgessinger
commented
Dec 21, 2022
tboldagh
approved these changes
Dec 21, 2022
📊 Physics performance monitoring for 5cc6030Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #1765 +/- ##
==========================================
- Coverage 49.46% 49.46% -0.01%
==========================================
Files 399 399
Lines 22099 22102 +3
Branches 10031 10031
==========================================
+ Hits 10931 10932 +1
- Misses 4201 4203 +2
Partials 6967 6967
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to facilitate backends where the calibrated size is calculated on demand, and can't easily be returned by reference.
See also #1743