Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Example of integrating HoughTransform example algorithm with python #1795

Merged
merged 16 commits into from
Mar 31, 2023

Conversation

tboldagh
Copy link
Contributor

This PR adds python example of configuring the HT as alternative seeder. It is off by default.
Side fixes/improvements:

  • the HT seeder exceptions start with the name of it so one knows where to look.
  • whiteboard prints a bit more info when the types that are read from the whiteboard are mismatching.

FI @jahreda

@tboldagh tboldagh added this to the next milestone Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1795 (b32bbbf) into main (a7cd583) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1795   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files         413      413           
  Lines       23606    23606           
  Branches    10681    10681           
=======================================
  Hits        11758    11758           
  Misses       4343     4343           
  Partials     7505     7505           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jan 24, 2023

📊 Physics performance monitoring for b32bbbf

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@gagnonlg gagnonlg added the 🚧 WIP Work-in-progress label Jan 24, 2023
@tboldagh tboldagh marked this pull request as ready for review February 15, 2023 07:10
@tboldagh tboldagh removed the 🚧 WIP Work-in-progress label Feb 28, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me. I think I already updated this component to the DataHandles, right?

@tboldagh
Copy link
Contributor Author

Hi experts that can merge. If I update this branch now to synch with te main does it have a chance to be merged soon?

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments from my side. happy to merge - just ping me

@andiwand andiwand added the Component - Examples Affects the Examples module label Mar 29, 2023
@andiwand
Copy link
Contributor

looks like the ci is stuck. could you push an empty commit @tboldagh ?

@kodiakhq kodiakhq bot merged commit 1f7443e into acts-project:main Mar 31, 2023
38 checks passed
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants