refactor: Material mapping howto for python bindings #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Improvement
|
I think it'd be best if @noemina reviews this. |
Codecov Report
@@ Coverage Diff @@
## main #1801 +/- ##
=======================================
Coverage 49.56% 49.56%
=======================================
Files 407 407
Lines 22618 22618
Branches 10316 10316
=======================================
Hits 11211 11211
Misses 4227 4227
Partials 7180 7180 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 199537bFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
AJPfleger
reviewed
Jan 27, 2023
Doc improvements Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
noemina
reviewed
Jan 30, 2023
|
Hello, it seems pretty straightforward. I only have one comment on the documentation. |
|
I had to do some minor modification to the doc to pass the CI can someone reapprove ? |
AJPfleger
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been procrastinating on this for way too long. In this PR, I update the material mapping howto to use the python bindings. The relevant bindings have been tested and updated to work as expected. I Also done some update of the plotting script (even if they should probably be phased out) to solve the remaining issue with them.
In the near future I plan to update the material mapping autotuning, once it is done I will update the corresponding doc.
The hashes changes come from the fact the validation vertex spread are now set properly to 0 by default.