refactor: GX2F uses TrackContainer + log message cleanup #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Physics performance monitoring for 46b9694Full report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #1823 +/- ##
==========================================
- Coverage 49.56% 49.53% -0.03%
==========================================
Files 407 407
Lines 22618 22629 +11
Branches 10316 10326 +10
==========================================
- Hits 11211 11210 -1
- Misses 4227 4230 +3
- Partials 7180 7189 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AJPfleger
approved these changes
Feb 3, 2023
|
This has been approved but is not up2date: adding automerge flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contrary to what I said before, the GX2F was not yet using
Acts::TrackContainer. This PR switches it over.I also cleaned up some of the log messages in the Chi2 fitter and algorithm, the prefixes there are unnecessary because the loggers already print their own names.