Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move traj to proto track converter to separate target #1837

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Feb 8, 2023

In preparation for adding a central Track to Trajectories converter

Blocked by:

@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Feb 8, 2023
@paulgessinger paulgessinger added this to the next milestone Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #1837 (b332b2f) into main (aa3dea8) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head b332b2f differs from pull request most recent head b7486a6. Consider uploading reports for the commit b7486a6 to get more accurate results

@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   49.50%   49.53%   +0.03%     
==========================================
  Files         407      407              
  Lines       22646    22629      -17     
  Branches    10334    10326       -8     
==========================================
  Hits        11210    11210              
+ Misses       4247     4230      -17     
  Partials     7189     7189              
Impacted Files Coverage Δ
Core/include/Acts/Geometry/Extent.hpp 95.00% <0.00%> (ø)
Core/include/Acts/Geometry/ProtoDetector.hpp 100.00% <0.00%> (ø)
...de/Acts/Geometry/KDTreeTrackingGeometryBuilder.hpp 100.00% <0.00%> (ø)
Core/include/Acts/Navigation/NavigationState.hpp
...nclude/Acts/Navigation/NavigationStateUpdators.hpp
...include/Acts/Navigation/DetectorVolumeUpdators.hpp
...re/include/Acts/Navigation/NavigationDelegates.hpp
...lude/Acts/Navigation/SurfaceCandidatesUpdators.hpp
.../include/Acts/Navigation/DetectorVolumeFinders.hpp
...e/Acts/Geometry/detail/NavigationStateUpdators.hpp 72.41% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Feb 10, 2023
@andiwand andiwand self-assigned this Feb 10, 2023
@andiwand andiwand added Component - Examples Affects the Examples module automerge labels Feb 10, 2023
@kodiakhq kodiakhq bot merged commit 1de6551 into acts-project:main Feb 10, 2023
@github-actions
Copy link

📊 Physics performance monitoring for b7486a6

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

kodiakhq bot pushed a commit that referenced this pull request Feb 13, 2023
This is needed to be able to write a general tracks to trajectories converter.

This requires writing the tracks to the white board so the track state container stays alive after the algorithm ends.

Blocked by:
- #1836 
- #1837 
- #1838
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants