-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wire geoid hooks in g4 detector #1843
feat: wire geoid hooks in g4 detector #1843
Conversation
andiwand
commented
Feb 9, 2023
- G4 detector was not able to handle geoid hooks
- sneaked in some cleanups - we can break this out if necessary
Codecov Report
@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
- Coverage 49.53% 49.53% -0.01%
==========================================
Files 407 407
Lines 22629 22631 +2
Branches 10326 10326
==========================================
Hits 11210 11210
- Misses 4230 4232 +2
Partials 7189 7189
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for a742890Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think when you format the python code, we get this in.