Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wire geoid hooks in g4 detector #1843

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Feb 9, 2023

  • G4 detector was not able to handle geoid hooks
  • sneaked in some cleanups - we can break this out if necessary

@andiwand andiwand added the Component - Examples Affects the Examples module label Feb 9, 2023
@andiwand andiwand added this to the next milestone Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1843 (a742890) into main (d4217aa) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1843      +/-   ##
==========================================
- Coverage   49.53%   49.53%   -0.01%     
==========================================
  Files         407      407              
  Lines       22629    22631       +2     
  Branches    10326    10326              
==========================================
  Hits        11210    11210              
- Misses       4230     4232       +2     
  Partials     7189     7189              
Impacted Files Coverage Δ
Core/include/Acts/Geometry/Extent.hpp 95.00% <ø> (ø)
...de/Acts/Geometry/KDTreeTrackingGeometryBuilder.hpp 100.00% <ø> (ø)
.../include/Acts/Geometry/TrackingGeometryBuilder.hpp 100.00% <ø> (ø)
Core/src/Geometry/TrackingGeometryBuilder.cpp 43.47% <0.00%> (-4.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

📊 Physics performance monitoring for a742890

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think when you format the python code, we get this in.

@asalzburger asalzburger merged commit dd9965f into acts-project:main Feb 9, 2023
@github-actions github-actions bot removed the automerge label Feb 9, 2023
@andiwand andiwand deleted the feature-wire-geoid-hook-in-g4detector branch February 9, 2023 14:54
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants