Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add rho-cut to the ParticleSelector for g4 ODD #1856

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

pbutti
Copy link
Contributor

@pbutti pbutti commented Feb 11, 2023

This PR closes #1855

@pbutti pbutti changed the title fix:Add rho-cut to the ParticleSelector for g4 ODD fix: Add rho-cut to the ParticleSelector for g4 ODD Feb 11, 2023
@github-actions
Copy link

github-actions bot commented Feb 11, 2023

📊 Physics performance monitoring for 35b7cc5

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #1856 (35b7cc5) into main (c2ef676) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1856   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth added Bug Something isn't working Component - Examples Affects the Examples module labels Feb 11, 2023
@benjaminhuth benjaminhuth added this to the next milestone Feb 11, 2023
@benjaminhuth benjaminhuth merged commit 9fbfb77 into acts-project:main Feb 11, 2023
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Feb 13, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: full_chain_odd.py crashes when running G4 ODD after few k events
3 participants