Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Track Finding and Fitting algorithms output Tracks only #1858

Merged

Conversation

paulgessinger
Copy link
Member

This removes the Trajectories output writing, completely moving to the separate conversion algorithm introduced in #1857

Blocked by:

@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Feb 13, 2023
@paulgessinger paulgessinger added this to the next milestone Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1858 (5995f31) into main (4fac4ae) will not change coverage.
The diff coverage is n/a.

❗ Current head 5995f31 differs from pull request most recent head 2974d50. Consider uploading reports for the commit 2974d50 to get more accurate results

@@           Coverage Diff           @@
##             main    #1858   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 13, 2023

📊 Physics performance monitoring for 2974d50

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Feb 14, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@andiwand andiwand self-assigned this Feb 14, 2023
@andiwand andiwand added the Component - Examples Affects the Examples module label Feb 14, 2023
@andiwand
Copy link
Contributor

@paulgessinger did you want to hold this back for the track selector changes? otherwise I would assign automerge to it

@kodiakhq kodiakhq bot merged commit 9b60cd0 into acts-project:main Feb 14, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants