Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply particle filter change to full_chain_itk.py #1873

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

toyamaza
Copy link
Contributor

addFatras updated in #1851

@toyamaza toyamaza added this to the next milestone Feb 16, 2023
@andiwand andiwand self-assigned this Feb 16, 2023
@andiwand andiwand added Component - Examples Affects the Examples module automerge labels Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1873 (d946d77) into main (d857080) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1873   +/-   ##
=======================================
  Coverage   49.50%   49.50%           
=======================================
  Files         407      407           
  Lines       22646    22646           
  Branches    10334    10334           
=======================================
  Hits        11210    11210           
  Misses       4247     4247           
  Partials     7189     7189           
Impacted Files Coverage Δ
Core/include/Acts/Detector/Detector.hpp 87.50% <ø> (ø)
Core/include/Acts/Detector/DetectorVolume.hpp 89.65% <ø> (ø)
Core/include/Acts/Detector/Portal.hpp 90.90% <ø> (ø)
Core/include/Acts/Detector/PortalGenerators.hpp 55.00% <ø> (ø)
Core/include/Acts/Detector/PortalHelper.hpp 33.33% <ø> (ø)
Core/include/Acts/Detector/ProtoDetector.hpp 100.00% <ø> (ø)
...de/Acts/Geometry/KDTreeTrackingGeometryBuilder.hpp 100.00% <ø> (ø)
.../include/Acts/Navigation/DetectorVolumeFinders.hpp 73.68% <ø> (ø)
...lude/Acts/Navigation/SurfaceCandidatesUpdators.hpp 70.73% <ø> (ø)
Core/src/Detector/Detector.cpp 47.61% <ø> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

📊 Physics performance monitoring for d946d77

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit 910ec13 into acts-project:main Feb 16, 2023
@toyamaza toyamaza deleted the itkchain_update branch February 16, 2023 23:50
@paulgessinger paulgessinger modified the milestones: next, v23.3.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants