-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added python bindings for SurfaceTypes #1893
feat: added python bindings for SurfaceTypes #1893
Conversation
Hi @dimitra97 - super happy to see your first PR appear in less than a week! Excellent job. In the future, you can:
I approved this as your first contribution, and the CI system will now run un tell us if everything went smoothly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov Report
@@ Coverage Diff @@
## main #1893 +/- ##
=======================================
Coverage 49.44% 49.44%
=======================================
Files 408 408
Lines 22704 22704
Branches 10371 10371
=======================================
Hits 11226 11226
Misses 4266 4266
Partials 7212 7212 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 498b0aaFull report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
@paulgessinger / @asalzburger I think we are missing some permissions for the CI here? |
Annoyingly, GitHub's permission model only allows people with write access to set milestones, so one of us has to do it. |
This PR adds python enum bindings as
acts.SurfaceType
. Those will be needed in order to set the desired surface type for Geant4 translation, in case the auto-detection does not work (e.g. through the ambiguity ifG4Tubs
areCylinderSurface
orStrawSurface
.