Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added python bindings for SurfaceTypes #1893

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

dimitra97
Copy link
Contributor

@dimitra97 dimitra97 commented Feb 23, 2023

This PR adds python enum bindings as acts.SurfaceType. Those will be needed in order to set the desired surface type for Geant4 translation, in case the auto-detection does not work (e.g. through the ambiguity if G4Tubs are CylinderSurface or StrawSurface.

@asalzburger asalzburger added this to the next milestone Feb 23, 2023
@asalzburger
Copy link
Contributor

Hi @dimitra97 - super happy to see your first PR appear in less than a week! Excellent job.

In the future, you can:

  • remove the text (checklist) in the template, that is just a bit for following up.
  • set a next milestone, which means we consider it for the next release.

I approved this as your first contribution, and the CI system will now run un tell us if everything went smoothly.

Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@benjaminhuth benjaminhuth added Component - Examples Affects the Examples module automerge and removed automerge labels Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1893 (498b0aa) into main (a2ddf8f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1893   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files         408      408           
  Lines       22704    22704           
  Branches    10371    10371           
=======================================
  Hits        11226    11226           
  Misses       4266     4266           
  Partials     7212     7212           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Feb 23, 2023

📊 Physics performance monitoring for 498b0aa

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand
Copy link
Contributor

@paulgessinger / @asalzburger I think we are missing some permissions for the CI here?

@paulgessinger
Copy link
Member

* set a `next` milestone, which means we consider it for the next release.

Annoyingly, GitHub's permission model only allows people with write access to set milestones, so one of us has to do it.

@benjaminhuth benjaminhuth merged commit a5c233b into acts-project:main Feb 24, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.5.0 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants