Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new ACTSVG version for MS chambers #1899

Merged

Conversation

asalzburger
Copy link
Contributor

This is the new ACTSVG version for facilitating the debugging of multi-wire chamber setups, such as the ATLAS MDT cambers.

An example display for such as setup is attached, and can with this version be implemented within ACTS:

Screenshot 2023-02-27 at 10 39 25

@github-actions
Copy link

📊 Physics performance monitoring for 8016d18

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1899 (8016d18) into main (17f1d4a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1899   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files         408      408           
  Lines       22704    22704           
  Branches    10371    10371           
=======================================
  Hits        11226    11226           
  Misses       4266     4266           
  Partials     7212     7212           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth benjaminhuth changed the title chore: new version for MS chambers chore: new ACTSVG version for MS chambers Feb 27, 2023
@asalzburger asalzburger added this to the next milestone Feb 28, 2023
@asalzburger
Copy link
Contributor Author

Hi @noemina - I assigned you as a reviewer, actually this only changes the version number, so not much to review, this is just for your and @dimitra97 to be aware - but if in the run you can press the approve button, we can get that in.

@benjaminhuth benjaminhuth added Infrastructure Changes to build tools, continous integration, ... automerge labels Feb 28, 2023
@kodiakhq kodiakhq bot merged commit 466c03c into acts-project:main Feb 28, 2023
@asalzburger asalzburger deleted the feat-bump-actsvg-version-v0.4.30 branch February 28, 2023 09:21
@paulgessinger paulgessinger modified the milestones: next, v23.5.0 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants