Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental navigator for experimental geometry #1932

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Mar 9, 2023

first draft of a navigator which can deal with the new geometry, navigation delegates and navigation state

I also added a small unit test that navigates through a box in a box

it also seemed to successfully find all the surfaces in a muon chamber mock up geometry

@andiwand andiwand added the 🚧 WIP Work-in-progress label Mar 9, 2023
@andiwand andiwand added this to the next milestone Mar 9, 2023
@andiwand
Copy link
Contributor Author

andiwand commented Mar 9, 2023

moved the code into this branch/PR @asalzburger @dimitra97

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #1932 (c67dc85) into main (32b802c) will increase coverage by 0.02%.
The diff coverage is 51.12%.

@@            Coverage Diff             @@
##             main    #1932      +/-   ##
==========================================
+ Coverage   49.57%   49.59%   +0.02%     
==========================================
  Files         412      413       +1     
  Lines       23310    23443     +133     
  Branches    10604    10666      +62     
==========================================
+ Hits        11555    11627      +72     
- Misses       4318     4336      +18     
- Partials     7437     7480      +43     
Impacted Files Coverage Δ
Core/include/Acts/Detector/ProtoDetector.hpp 100.00% <ø> (ø)
...include/Acts/Navigation/DetectorVolumeUpdators.hpp 70.37% <ø> (ø)
...lude/Acts/Navigation/SurfaceCandidatesUpdators.hpp 73.01% <0.00%> (+3.24%) ⬆️
Core/src/Detector/DetectorVolume.cpp 48.71% <ø> (+2.81%) ⬆️
Core/include/Acts/Navigation/NextNavigator.hpp 47.45% <47.45%> (ø)
...include/Acts/Navigation/NavigationStateFillers.hpp 85.71% <85.71%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

📊 Physics performance monitoring for c67dc85

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@andiwand andiwand marked this pull request as ready for review March 11, 2023 15:23
@andiwand andiwand added Component - Core Affects the Core module and removed 🚧 WIP Work-in-progress labels Mar 11, 2023
Core/include/Acts/Navigation/NextNavigator.hpp Outdated Show resolved Hide resolved
Core/src/Detector/DetectorVolume.cpp Show resolved Hide resolved
Copy link
Contributor Author

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently I forgot to press the submit button again 😄

here are my comments from yesterday

Core/include/Acts/Navigation/NextNavigator.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Navigation/NextNavigator.hpp Outdated Show resolved Hide resolved
@andiwand
Copy link
Contributor Author

so I think two things are missing now: the start and the target surface. I think I will add it to stay compatible with the existing navigator and we will need it for the fitters anyway.

the other thing would be to make the unit test actually assert on something

IMO we could merge as is because it is just experimental and it will make prototyping for muons easier

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this in & we can refine if needed in a follow-up.

@asalzburger
Copy link
Contributor

@andiwand - ok, let's move this in, such that we can establish first testbeds, if we need refining/updating we will anyway learn this when using the new navigation interface.

@asalzburger
Copy link
Contributor

Great job, by the way!

@kodiakhq kodiakhq bot merged commit 34af411 into acts-project:main Mar 24, 2023
1 check passed
@andiwand andiwand deleted the experimental-navigator-for-experimental-geometry branch March 24, 2023 09:43
@paulgessinger paulgessinger removed this from the next milestone Mar 31, 2023
@paulgessinger paulgessinger added this to the v24.0.0 milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants