feat: Refitting algorithm #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Component - Examples
There was a problem hiding this comment.
Didn't look through all of it yet. Looks good as far as I can tell, a few remarks here.
Also, can we hold this until after #1939, and move to the DataHandles immediately?
Examples/Algorithms/TrackFitting/include/ActsExamples/TrackFitting/TrackFitterFunction.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TrackFitting/src/AlreadyCalibratedCalibrator.cpp
Outdated
Show resolved
Hide resolved
benjaminhuth
added
🛑 blocked
Codecov Report
@@ Coverage Diff @@
## main #1940 +/- ##
=======================================
Coverage 49.83% 49.83%
=======================================
Files 421 421
Lines 23900 23900
Branches 10844 10844
=======================================
Hits 11910 11910
Misses 4367 4367
Partials 7623 7623
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 4193decFull report VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 27, 2023
I'm currently working on implementing a few different measurement/cluster calibration methods for a bona fide calibration study. The easiest way to run such a study would be to have the option to swap the calibrators on the python side so one does not need to either recompile everytime or duplicate the TrackFitting example for each different methods. Towards that end, I propose the following changes: - Rename `MeasurementCalibrator` to `PassThroughCalibrator`; - Create an abstract base class `MeasurementCalibrator` with a calibrate method which takes a measurement container as input; - Created a `PairedMeasurementCalibrator` class that binds a calibrator to a `MeasurementContainer`, to pass to the actual fitter; - Add machinery to instantiate the calibrators outside of the `execute()` loop. #1940 introduced a alternate path using a RefittingCalibrator instead of a MeasurementCalibrator. I did _not_ touch this code since I'm not sure if it makes sense to unify it with what I have planned -- any thoughts @benjaminhuth ? I propose to leave this as-is for the time being and re-assess once I push actual calibrators (shortly, hopefully).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, real refitting of tracks was not possible in the examples framework. The direct-fitter option of the
ActsExamples::TrackFittingAlgorithmwas broken due to the fact, that only measurement surfaces were added to the surface sequence, and thus e.g. the traversed material could differ.This adds
ActsExamples::RefittingAlgorithm, that uses the newActs::TrackContainerinfrastructure to enable a very simple interface: Just a input container and a output container.Furthermore, the
TrackFittingAlgorithmlooses thedirectFitoption. To make this work, also theTrackFitterFunctionhad to be refactored and was pulled out of theTrackFittingAlgorithm.