refactor: explicit init, pre step, post step for navigator interface

[andiwand]

my attempt to make the navigator code more readable. list of changes:

• explicit init instead of check and call in status
• status -> postStep because that's what is actually does and why it is called
• target -> preStep same as above

[codecov]

Codecov Report

Merging #1984 (32f9f2c) into main (765cad0) will decrease coverage by 0.03%.
The diff coverage is 54.01%.

❗ Current head 32f9f2c differs from pull request most recent head 0779586. Consider uploading reports for the commit 0779586 to get more accurate results

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
- Coverage   49.41%   49.39%   -0.03%     
==========================================
  Files         441      441              
  Lines       25176    25175       -1     
  Branches    11617    11616       -1     
==========================================
- Hits        12441    12434       -7     
- Misses       4481     4485       +4     
- Partials     8254     8256       +2     

Impacted Files	Coverage Δ
Core/include/Acts/Propagator/Propagator.ipp	40.25% <33.33%> (-0.77%)	⬇️
Core/include/Acts/Navigation/NextNavigator.hpp	47.65% <38.63%> (-2.35%)	⬇️
Core/include/Acts/Propagator/DirectNavigator.hpp	75.00% <54.54%> (+0.75%)	⬆️
Core/include/Acts/Propagator/Navigator.hpp	58.07% <61.29%> (-1.36%)	⬇️
...cts/Propagator/detail/VoidPropagatorComponents.hpp	91.66% <100.00%> (+0.75%)	⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊 Physics performance monitoring for 0779586

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[andiwand]

do you have some feedback on this @paulgessinger @benjaminhuth @asalzburger ?

[stale]

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

[andiwand]

could one of you have a look at this @asalzburger @paulgessinger - would also okay for me to close if you do not think it is relevant enough

[paulgessinger]

Could still be good for clarity, but I see the added complexity. @asalzburger what do you think?

[benjaminhuth]

I would actually like this to go in, because everytime I need to do something in the navigator, I need to figure out myself again, what the status and target calls actually do...

[andiwand]

This one actually only renames the functions and reorders the code in the navigator. That's why there is a lot of diff

The other PR #1987 was a bit more involved but I closed it now

[benjaminhuth]

Very nice. Only a minor code readablility suggestion, feel free to ignore it!