Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable interaction in truth_tracking_kalman.py #1990

Merged
merged 5 commits into from
Apr 5, 2023

Conversation

beomki-yeo
Copy link
Contributor

@beomki-yeo beomki-yeo commented Mar 25, 2023

This PR enables the material interaction in truth_tracking_kalman.
I did some case studies and I will let others judge which configuration (eta, momentum) is the best.

Case 1 (main)
Default momentum config
Eta: -2:2
No interaction

)

Case2 (This PR)
Default momentum config
Eta: -2:2
Yes interaction

)

Case3
10 GeV
Eta: -2:2
Yes interaction

))

Case4
10 GeV
Eta: 0:0
Yes interaction

)))

@beomki-yeo beomki-yeo marked this pull request as draft March 25, 2023 11:18
@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #1990 (49bd620) into main (0681a23) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1990   +/-   ##
=======================================
  Coverage   49.83%   49.83%           
=======================================
  Files         415      415           
  Lines       23593    23593           
  Branches    10681    10681           
=======================================
  Hits        11758    11758           
  Misses       4330     4330           
  Partials     7505     7505           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Mar 25, 2023

📊 Physics performance monitoring for 49bd620

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@beomki-yeo beomki-yeo marked this pull request as ready for review March 25, 2023 13:02
@beomki-yeo beomki-yeo changed the title Enable interaction in truth_tracking.py Enable interaction in truth_tracking_kalman.py Mar 25, 2023
@beomki-yeo
Copy link
Contributor Author

There is a (nagative) shift even for zero eta case - I think it is because b field is orthogonal to the particle direction which makes a curvature in the track.

@benjaminhuth
Copy link
Member

Is this OpenDataDetector or GenericDetector?

@beomki-yeo
Copy link
Contributor Author

beomki-yeo commented Mar 27, 2023

It is ODD because the plots were generated by physmon.py

@beomki-yeo beomki-yeo marked this pull request as draft March 28, 2023 19:55
@andiwand andiwand added this to the next milestone Mar 29, 2023
@andiwand andiwand added Component - Examples Affects the Examples module automerge labels Mar 29, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is safe to merge because the fitter is already using interactions

if we want to check w/o interactions we should do this for sim and reco

@andiwand andiwand marked this pull request as ready for review March 29, 2023 15:40
@andiwand andiwand changed the title Enable interaction in truth_tracking_kalman.py test: Enable interaction in truth_tracking_kalman.py Mar 29, 2023
@andiwand
Copy link
Contributor

@beomki-yeo can you update the reference data?

@beomki-yeo
Copy link
Contributor Author

Will do this by the end of the day

@beomki-yeo
Copy link
Contributor Author

It's updated but there was a hiccup in Mac - someone can run it again?

@beomki-yeo
Copy link
Contributor Author

@andiwand Do you know what this is about? The error came from linux_examples_test

Run /usr/local/bin/geant4-config --install-datasets && source /usr/local/bin/thisroot.sh && source /usr/local/bin/thisdd4hep_only.sh && source /usr/local/bin/geant4.sh && source build/python/setup.sh && export LD_LIBRARY_PATH=$PWD/build/thirdparty/OpenDataDetector/factory:$LD_LIBRARY_PATH && pip3 install -r Examples/Python/tests/requirements.txt && pytest -rFsv -v
+ created download cache
+ downloading G4NDL.4.6.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    55  100    55    0     0     78      0 --:--:-- --:--:-- --:--:--    78

  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
100   228  100   228    0     0    149      0  0:00:01  0:00:01 --:--:--   489

100   191  100   191    0     0    115      0  0:00:01  0:00:01 --:--:--   115
+ checking md5 of G4NDL.4.6.tar.gz
- md5 mismatch for 'G4NDL.4.6.tar.gz' : 8f388d08d9de80d8255e1762d8b81d58(actual) != d07e43499f607e01f2c1ce06d7a09f3e(expected)
+ cleaned download cache
- dataset installation failed
Error: Process completed with exit code 1.

@andiwand
Copy link
Contributor

andiwand commented Apr 3, 2023

never seen that before. I restarted the runs in hope that is was a random failure

@beomki-yeo
Copy link
Contributor Author

The error is still there :/

@andiwand
Copy link
Contributor

andiwand commented Apr 3, 2023

oh no... lets see if that pops up in other PRs. which I would expect?

@beomki-yeo
Copy link
Contributor Author

Yeah it also exists in #2009

@andiwand
Copy link
Contributor

andiwand commented Apr 3, 2023

looks like all the cern data links are broken atm 😄

@andiwand
Copy link
Contributor

andiwand commented Apr 3, 2023

#2011 should fix the issue

@andiwand
Copy link
Contributor

andiwand commented Apr 4, 2023

@beomki-yeo there seems to be one more problem with physmon ref data. can you take a look?

@beomki-yeo
Copy link
Contributor Author

beomki-yeo commented Apr 4, 2023

All red flags come from truth_tracking.html You can take a look here:
https://drive.google.com/drive/folders/1g1HIdHzm1z7Z-yf4F_VzjTmWw7N-cD-0?usp=share_link

I am also good to discuss at today's meeting

@paulgessinger
Copy link
Member

@beomki-yeo
Copy link
Contributor Author

@paulgessinger Am I also able to get the link? Genereting html is a drag

@andiwand
Copy link
Contributor

andiwand commented Apr 4, 2023

@beomki-yeo I think you can get it from this one #1990 (comment)

there is a reference file for the kalman truth tracking in CI/physmon/reference. can you update it with the one the CI spits out?

@paulgessinger
Copy link
Member

@andiwand can you reapprove after the added force push?

@andiwand
Copy link
Contributor

andiwand commented Apr 5, 2023

huch I thought I did already

@kodiakhq kodiakhq bot merged commit ff07dd9 into acts-project:main Apr 5, 2023
37 checks passed
@github-actions github-actions bot removed the automerge label Apr 5, 2023
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants