-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Enable interaction in truth_tracking_kalman.py
#1990
test: Enable interaction in truth_tracking_kalman.py
#1990
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1990 +/- ##
=======================================
Coverage 49.83% 49.83%
=======================================
Files 415 415
Lines 23593 23593
Branches 10681 10681
=======================================
Hits 11758 11758
Misses 4330 4330
Partials 7505 7505 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 49bd620Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
truth_tracking_kalman.py
There is a (nagative) shift even for zero eta case - I think it is because b field is orthogonal to the particle direction which makes a curvature in the track. |
Is this OpenDataDetector or GenericDetector? |
It is ODD because the plots were generated by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is safe to merge because the fitter is already using interactions
if we want to check w/o interactions we should do this for sim and reco
truth_tracking_kalman.py
truth_tracking_kalman.py
@beomki-yeo can you update the reference data? |
Will do this by the end of the day |
a37464c
to
f833b9f
Compare
It's updated but there was a hiccup in Mac - someone can run it again? |
…_enable_interaction
@andiwand Do you know what this is about? The error came from
|
never seen that before. I restarted the runs in hope that is was a random failure |
The error is still there :/ |
oh no... lets see if that pops up in other PRs. which I would expect? |
Yeah it also exists in #2009 |
looks like all the cern data links are broken atm 😄 |
#2011 should fix the issue |
@beomki-yeo there seems to be one more problem with physmon ref data. can you take a look? |
All red flags come from truth_tracking.html You can take a look here: I am also good to discuss at today's meeting |
@paulgessinger Am I also able to get the link? Genereting html is a drag |
@beomki-yeo I think you can get it from this one #1990 (comment) there is a reference file for the kalman truth tracking in |
4e77ea3
to
52b25cb
Compare
@andiwand can you reapprove after the added force push? |
huch I thought I did already |
This PR enables the material interaction in
truth_tracking_kalman
.I did some case studies and I will let others judge which configuration (eta, momentum) is the best.
Case 1 (main)
Default momentum config
Eta: -2:2
No interaction
)
Case2 (This PR)
Default momentum config
Eta: -2:2
Yes interaction
)
Case3
10 GeV
Eta: -2:2
Yes interaction
))
Case4
10 GeV
Eta: 0:0
Yes interaction
)))