Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Ambiguity solvers now use Track containers #1996

Merged

Conversation

Corentin-Allaire
Copy link
Contributor

This PR change both Ambiguity solvers to use the Track container instead of the Trajectory ones.

@Corentin-Allaire Corentin-Allaire added Improvement Changes to an existing feature Impact - Minor Nuissance bug and/or affects only a single module Component - Examples Affects the Examples module labels Mar 27, 2023
@Corentin-Allaire Corentin-Allaire added this to the next milestone Mar 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 27, 2023

📊 Physics performance monitoring for 30fd23a

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1996 (30fd23a) into main (4d1a846) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1996   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files         413      413           
  Lines       23596    23596           
  Branches    10676    10676           
=======================================
  Hits        11753    11753           
  Misses       4342     4342           
  Partials     7501     7501           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 4d7e280 into acts-project:main Mar 28, 2023
1 check passed
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants