-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add SVG visualization functionality for indexed surfaces #2033
feat: add SVG visualization functionality for indexed surfaces #2033
Conversation
@niermann999 - I selected you as a reviewer, as we will have to repeat this somewhat for |
Codecov Report
@@ Coverage Diff @@
## main #2033 +/- ##
=======================================
Coverage 49.85% 49.86%
=======================================
Files 421 421
Lines 23889 23886 -3
Branches 10843 10841 -2
=======================================
Hits 11911 11911
+ Misses 4357 4354 -3
Partials 7621 7621 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 8af7518Full report VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Plugins/ActSVG/include/Acts/Plugins/ActSVG/SurfaceSvgConverter.hpp
Outdated
Show resolved
Hide resolved
Plugins/ActSVG/include/Acts/Plugins/ActSVG/GridSvgConverter.hpp
Outdated
Show resolved
Hide resolved
Plugins/ActSVG/include/Acts/Plugins/ActSVG/GridSvgConverter.hpp
Outdated
Show resolved
Hide resolved
Plugins/ActSVG/include/Acts/Plugins/ActSVG/IndexedSurfacesSvgConverter.hpp
Show resolved
Hide resolved
Plugins/ActSVG/include/Acts/Plugins/ActSVG/IndexedSurfacesSvgConverter.hpp
Show resolved
Hide resolved
Hey @niermann999 - I think I addressed all your comments, the trivial conversions I simply closed, there are only a few for you to follow up then. |
Hm, I can't resolve the conversations, but the PR has a green light from my side |
I resolved those then, and rebated. |
…project#2033) This PR adds the possibility to visualise the `IndexedSurfaces` navigation delegates via the `ACTSVG` plugin. It also integrates `actsvg` into the proper versioning schema via the master `CMakeLists.txt`file, and pumps the version to 0.4.33 for some needed extra functionality. It allows to show the index grid and associations to surfaces that are pointed to: ![Screenshot 2023-04-14 at 13 27 29](https://user-images.githubusercontent.com/26623879/232032064-ceb001bc-473c-4fde-b44a-a012f3245a73.png)
This PR adds the possibility to visualise the
IndexedSurfaces
navigation delegates via theACTSVG
plugin.It also integrates
actsvg
into the proper versioning schema via the masterCMakeLists.txt
file,and pumps the version to 0.4.33 for some needed extra functionality.
It allows to show the index grid and associations to surfaces that are pointed to: