Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SVG visualization functionality for indexed surfaces #2033

Merged

Conversation

asalzburger
Copy link
Contributor

This PR adds the possibility to visualise the IndexedSurfaces navigation delegates via the ACTSVG plugin.

It also integrates actsvg into the proper versioning schema via the master CMakeLists.txtfile,
and pumps the version to 0.4.33 for some needed extra functionality.

It allows to show the index grid and associations to surfaces that are pointed to:

Screenshot 2023-04-14 at 13 27 29

@asalzburger asalzburger added this to the next milestone Apr 14, 2023
@asalzburger
Copy link
Contributor Author

@niermann999 - I selected you as a reviewer, as we will have to repeat this somewhat for detray within the context of our summer student project.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #2033 (02dd657) into main (be509fa) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 02dd657 differs from pull request most recent head 8af7518. Consider uploading reports for the commit 8af7518 to get more accurate results

@@           Coverage Diff           @@
##             main    #2033   +/-   ##
=======================================
  Coverage   49.85%   49.86%           
=======================================
  Files         421      421           
  Lines       23889    23886    -3     
  Branches    10843    10841    -2     
=======================================
  Hits        11911    11911           
+ Misses       4357     4354    -3     
  Partials     7621     7621           

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Apr 14, 2023

📊 Physics performance monitoring for 8af7518

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@asalzburger
Copy link
Contributor Author

Hey @niermann999 - I think I addressed all your comments, the trivial conversions I simply closed, there are only a few for you to follow up then.

@niermann999
Copy link
Contributor

Hey @niermann999 - I think I addressed all your comments, the trivial conversions I simply closed, there are only a few for you to follow up then.

Hm, I can't resolve the conversations, but the PR has a green light from my side

@asalzburger
Copy link
Contributor Author

I resolved those then, and rebated.

@asalzburger asalzburger added Component - Plugins Affects one or more Plugins automerge labels Apr 18, 2023
@kodiakhq kodiakhq bot merged commit 870bd9d into acts-project:main Apr 18, 2023
37 checks passed
@paulgessinger paulgessinger modified the milestones: next, v25.0.0 Apr 21, 2023
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Apr 25, 2023
…project#2033)

This PR adds the possibility to visualise the `IndexedSurfaces` navigation delegates via the `ACTSVG` plugin.

It also integrates `actsvg` into the proper versioning schema via the master `CMakeLists.txt`file,
and pumps the version to 0.4.33 for some needed extra functionality.

It allows to show the index grid and associations to surfaces that are pointed to:

![Screenshot 2023-04-14 at 13 27 29](https://user-images.githubusercontent.com/26623879/232032064-ceb001bc-473c-4fde-b44a-a012f3245a73.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants