feat: cylindrical detector component builder

[asalzburger]

This PR binds the development of the:

• internal DetectorVolume structure
• external DetectorVolume glueing

together and establishes a first set of tools for cylindrical detectors.

It also - with everything in place - introduced a clear separation between:

• virtual interfaces for detector building in interface
• implementation details that are not exposed in detail
• data classes and builders in top level

It is currently blocked by #1983

[codecov]

Codecov Report

Merging #2065 (d121e62) into main (3918f38) will increase coverage by 0.07%.
The diff coverage is 46.39%.

@@            Coverage Diff             @@
##             main    #2065      +/-   ##
==========================================
+ Coverage   49.32%   49.40%   +0.07%     
==========================================
  Files         427      434       +7     
  Lines       24833    24984     +151     
  Branches    11444    11524      +80     
==========================================
+ Hits        12250    12343      +93     
+ Misses       4514     4486      -28     
- Partials     8069     8155      +86     

Impacted Files	Coverage Δ
Core/include/Acts/Detector/DetectorVolume.hpp	74.28% <ø> (+30.28%)	⬆️
...re/include/Acts/Detector/LayerStructureBuilder.hpp	100.00% <ø> (ø)
.../Acts/Detector/detail/IndexedSurfacesGenerator.hpp	60.00% <ø> (ø)
...clude/Acts/Detector/detail/KdtSurfacesProvider.hpp	57.14% <ø> (+5.86%)	⬆️
...s/Detector/interface/IInternalStructureBuilder.hpp	100.00% <ø> (ø)
.../src/Detector/detail/CylindricalDetectorHelper.cpp	34.65% <31.95%> (+0.71%)	⬆️
Core/src/Detector/LayerStructureBuilder.cpp	35.57% <33.33%> (-0.62%)	⬇️
...clude/Acts/Detector/detail/ReferenceGenerators.hpp	43.75% <43.75%> (ø)
...include/Acts/Detector/detail/IndexedGridFiller.hpp	58.82% <50.00%> (ø)
Core/src/Detector/DetectorVolumeBuilder.cpp	50.00% <50.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[github-actions]

📊 Physics performance monitoring for d121e62

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu

IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

[asalzburger]

Hey @andiwand @noemina - this PR binds it all together & harmonies the prior PRs:

• it introduces very clear virtual Interfaces for geometry building
• it introduces everything to build cylindrical-like detectors

I will follow it by one showcasing building the ODD and then eventually the ITk.

[andiwand]

part 1

[andiwand]

part 2

[asalzburger]

Hi @noemina @andiwand - I have addressed all comments (that I then have resolved), the ones I added explanation I kept open for your cross-checking.

Please resolve them if the answer satisfies you.

[andiwand]

lets go