Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move MultiTrajectory tests to common suite #2092

Merged
merged 2 commits into from
May 5, 2023

Conversation

paulgessinger
Copy link
Member

This allows us to use these tests more like a compliance suite, and it
can be used to test other backend implementation (like the upcoming
PODIO one)

This allows us to use these tests more like a compliance suite, and it
can be used to test other backend implementation (like the upcoming
PODIO one)
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #2092 (156d1ea) into main (29d0e08) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2092   +/-   ##
=======================================
  Coverage   49.31%   49.32%           
=======================================
  Files         427      427           
  Lines       24828    24830    +2     
  Branches    11444    11444           
=======================================
+ Hits        12245    12247    +2     
  Misses       4514     4514           
  Partials     8069     8069           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 5, 2023

📊 Physics performance monitoring for 156d1ea

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@asalzburger asalzburger self-requested a review May 5, 2023 14:19
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kodiakhq kodiakhq bot merged commit 3ab60b5 into acts-project:main May 5, 2023
59 checks passed
@github-actions github-actions bot removed the automerge label May 5, 2023
@paulgessinger paulgessinger modified the milestones: next, v26.0.0 May 22, 2023
kodiakhq bot pushed a commit that referenced this pull request Oct 23, 2023
This PR adds a self-contained PODIO plugin, independent from the EDM4hep plugin. It implements backends for the `TrackContainer` and `MultiTrajectory` EDM. Tests are included for conversion of both EDM types.

Blocked by:
- #2093 
- #2092 
- #2091 
- #2090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants