Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add full cov and pulls to VertexPerformanceWriter #2119

Merged

Conversation

andiwand
Copy link
Contributor

since people are looking more closely into vertex performance right now this might be helpful

@andiwand andiwand added the Component - Examples Affects the Examples module label May 10, 2023
@andiwand andiwand added this to the next milestone May 10, 2023
@andiwand
Copy link
Contributor Author

cc @vmmcairo @pbutti

@github-actions
Copy link

github-actions bot commented May 10, 2023

📊 Physics performance monitoring for aae50be

🟥 ERROR The result has missing elements!
This is likely a physmon job failure

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

🖼️ ivf_seeded_plots/diffx.pdf ❌🖼️ ivf_seeded_plots/diffy.pdf ❌🖼️ ivf_seeded_plots/diffz.pdf ❌

IVF truth_smeared

🖼️ ivf_truth_smeared_plots/diffx.pdf ❌🖼️ ivf_truth_smeared_plots/diffy.pdf ❌🖼️ ivf_truth_smeared_plots/diffz.pdf ❌

IVF truth_estimated

🖼️ ivf_truth_estimated_plots/diffx.pdf ❌🖼️ ivf_truth_estimated_plots/diffy.pdf ❌🖼️ ivf_truth_estimated_plots/diffz.pdf ❌

IVF orthogonal

🖼️ ivf_orthogonal_plots/diffx.pdf ❌🖼️ ivf_orthogonal_plots/diffy.pdf ❌🖼️ ivf_orthogonal_plots/diffz.pdf ❌

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #2119 (aae50be) into main (9e65ec3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2119   +/-   ##
=======================================
  Coverage   49.45%   49.45%           
=======================================
  Files         434      434           
  Lines       25019    25019           
  Branches    11529    11529           
=======================================
  Hits        12373    12373           
  Misses       4494     4494           
  Partials     8152     8152           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@paulgessinger
Copy link
Member

This probably needs updates in the associated plotting script so it doesn't break physmon.

@paulgessinger
Copy link
Member

Can we keep the FPE monitoring? Also seems unrelated to what the title says this PR does?

@andiwand
Copy link
Contributor Author

Can we keep the FPE monitoring? Also seems unrelated to what the title says this PR does?

the CI is crashing because of the FPE and I also face FPEs locally. It seems to highly depend on the rng at the moment and since we have no way of masking them and I have no time of chasing them all I dont see any other option

@andiwand andiwand added the 🚧 WIP Work-in-progress label May 11, 2023
@andiwand andiwand removed the 🚧 WIP Work-in-progress label May 16, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented May 16, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot merged commit c59801e into acts-project:main May 16, 2023
53 checks passed
@andiwand andiwand deleted the feature-vtx-perf-writer-full-cov-and-pulls branch May 16, 2023 20:18
@paulgessinger paulgessinger modified the milestones: next, v26.0.0 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants