refactor!: Split helper header into multiple files #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent initiative! |
paulgessinger
changed the title
paulgessinger
approved these changes
May 26, 2023
andiwand
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2153 +/- ##
=======================================
Coverage 49.50% 49.51%
=======================================
Files 436 439 +3
Lines 25128 25128
Branches 11605 11603 -2
=======================================
+ Hits 12440 12441 +1
Misses 4431 4431
+ Partials 8257 8256 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
changed the title
📊 Physics performance monitoring for d9374fcSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
|
CI is passing now - could you re-approve? @paulgessinger @asalzburger |
paulgessinger
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2151 I discovered that modifying
Helpers.hppbasically triggers a full rebuild and that we put a bunch of different stuff into it. In this PR I try to improve things by splitting upHelpers.hppinto multiple headers