feat: Add ability to skip grid bins in SP grouping and add ITk "fast" tracking config for seeding #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
added
🚧 WIP
Codecov Report
@@ Coverage Diff @@
## main #2166 +/- ##
==========================================
- Coverage 49.65% 49.57% -0.08%
==========================================
Files 453 451 -2
Lines 25534 25464 -70
Branches 11708 11690 -18
==========================================
- Hits 12679 12624 -55
- Misses 4574 4576 +2
+ Partials 8281 8264 -17
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Is there any way to make this non-breaking by using default arguments? |
LuisFelipeCoelho
changed the title
|
I have discussed with @paulgessinger and I realised that this is actually not a breaking change because it just adds new config parameters that are defaulted to something that won't change the performance or the build |
📊: Physics performance monitoring for aa5f33dphysmon summary
|
CarloVarni
reviewed
May 31, 2023
CarloVarni
reviewed
Jun 15, 2023
|
@LuisFelipeCoelho any news on this? |
|
I have completely removed the variables and replaced by a delegate (#2326). I also replaced the name |
LuisFelipeCoelho
changed the title
LuisFelipeCoelho
changed the title
paulgessinger
approved these changes
Aug 3, 2023
paulgessinger
changed the title
paulgessinger
pushed a commit
that referenced
this pull request
Aug 10, 2023
Protection for large number of bins which is set by default to `std::numeric_limits<int>::max()` This comes from PR #2166, I am splitting the changes into smaller PRs.
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 24, 2023
This PR adds an option to include experimental specific cuts to discard bottom-middle dublets in a certain (r, eta) region of the detector. This PR is related to the implementation of the ITk "fast tracking" configuration from PR #2166 (I am splitting the changes to make it more organised @CarloVarni @noemina) For the integration with Athena we will need to implement something like that in Athena: ``` m_finderCfg.experimentCuts.connect( [](const void*, const float& bottomRadius, const float& cotTheta) -> bool { if (bottomRadius < fastTrackingRMin and (cotTheta > fastTrackingCotThetaMax or cotTheta < -fastTrackingCotThetaMax)) { return false; } return true; } ``` where: ``` float fastTrackingRMin = 50. * Acts::UnitConstants::mm; float fastTrackingCotThetaMax = 1.5; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ITk fastTracking configuration for the seeding, which includes:
binnedSPGroupthat allow us to skip z bins for middle SPs in the search for neighbours SPs