Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include array in VectorHelpers.hpp #2183

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

CarloVarni
Copy link
Collaborator

missing include causing compilation issues

@paulgessinger paulgessinger changed the title fix: include array fix: include array in VectorHelpers.hpp Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #2183 (669927e) into main (724f155) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2183   +/-   ##
=======================================
  Coverage   49.48%   49.48%           
=======================================
  Files         439      439           
  Lines       25126    25126           
  Branches    11599    11599           
=======================================
  Hits        12433    12433           
  Misses       4443     4443           
  Partials     8250     8250           
Impacted Files Coverage Δ
Core/include/Acts/Utilities/VectorHelpers.hpp 90.47% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

📊 Physics performance monitoring for 669927e

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Jun 7, 2023
Copy link
Member

@LuisFelipeCoelho LuisFelipeCoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CarloVarni! just missing the format

Copy link
Contributor

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the format is fixed

@andiwand andiwand added the Component - Core Affects the Core module label Jun 7, 2023
@kodiakhq kodiakhq bot merged commit 6029679 into acts-project:main Jun 7, 2023
51 checks passed
@github-actions github-actions bot removed the automerge label Jun 7, 2023
@CarloVarni CarloVarni deleted the missingInclude branch June 8, 2023 07:49
@paulgessinger paulgessinger modified the milestones: next, v27.0.0 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants