fix: FPE in FATRAS hit direction #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
approved these changes
Jun 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #2189 +/- ##
=======================================
Coverage 49.41% 49.41%
=======================================
Files 441 441
Lines 25176 25176
Branches 11617 11617
=======================================
Hits 12441 12441
Misses 4481 4481
Partials 8254 8254 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for a92bb9dSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
reviewed
Jun 9, 2023
| @@ -88,9 +88,9 @@ class Hit { | |||
| } | |||
| /// Average normalized particle direction vector through the surface. | |||
| Vector3 unitDirection() const { | |||
There was a problem hiding this comment.
just for reference - it might be better to not average the direction but stick to either before or after. I think for digitization we should use before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered FPEs in the calculation of the average direction of FATRAS hits.
Currently we do this:
This fails if the norm of either of the three momenta is invalid or zero. I think Eigen has checks against this but we do the division manually.
I think this is equivalent to:
Thoughts?