refactor: Indexed surfaces generator #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
dimitra97
force-pushed
the
indexed-surfaces
branch
from
93b2109
to
c165803
Compare
AJPfleger
reviewed
Jun 22, 2023
Tests/UnitTests/Core/Detector/IndexedSurfacesGeneratorTests.cpp
Outdated
Show resolved
Hide resolved
Examples/Detectors/MuonSpectrometerMockupDetector/MuonChamber.gdml
Outdated
Show resolved
Hide resolved
dimitra97
force-pushed
the
indexed-surfaces
branch
from
7282932
to
b082dcc
Compare
Codecov Report
@@ Coverage Diff @@
## main #2234 +/- ##
==========================================
- Coverage 49.31% 49.31% -0.01%
==========================================
Files 447 448 +1
Lines 25153 25152 -1
Branches 11570 11570
==========================================
- Hits 12405 12404 -1
Misses 4558 4558
Partials 8190 8190
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for a1c9006Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
asalzburger
previously approved these changes
Jul 6, 2023
dimitra97
force-pushed
the
indexed-surfaces
branch
from
27eca5f
to
479c627
Compare
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
dimitra97
force-pushed
the
indexed-surfaces
branch
from
479c627
to
1e1bd8a
Compare
added 3 commits
July 18, 2023 21:27
andiwand
reviewed
Jul 20, 2023
There was a problem hiding this comment.
@dimitra97 is this ready to be merged?
I just had a quick look and didn't see anything controversial.
If ready, I am happy to merge because otherwise this will cause conflicts with soon to be done refactors
Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
yes thank you :) |
andiwand
approved these changes
Jul 20, 2023
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
This PR mainly changes the `IndexedSurfacesGenerator.hpp ` in order to accept other types of Navigation Delegates for the indexed surfaces, by providing a template class to the struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly changes the
IndexedSurfacesGenerator.hppin order to accept other types of Navigation Delegates for the indexed surfaces, by providing a template class to the struct.