Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Acts::zip to take arbitrary number of ranges #2236

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Jun 22, 2023

This allows finally something like this for an arbitray amount of ranges / containers:

for(const auto &[a, b, c] : Acts::zip(ra, rb, rc)) {
  // do something
}

Also adds unit test for this.

@benjaminhuth benjaminhuth added the Improvement Changes to an existing feature label Jun 22, 2023
@benjaminhuth benjaminhuth added this to the next milestone Jun 22, 2023
@github-actions github-actions bot added the Component - Core Affects the Core module label Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #2236 (edd9829) into main (71e4f2d) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
- Coverage   49.36%   49.35%   -0.01%     
==========================================
  Files         445      445              
  Lines       25259    25263       +4     
  Branches    11646    11650       +4     
==========================================
  Hits        12468    12468              
  Misses       4511     4511              
- Partials     8280     8284       +4     
Impacted Files Coverage Δ
Core/include/Acts/Utilities/Zip.hpp 71.42% <60.00%> (-28.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

📊 Physics performance monitoring for edd9829

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kodiakhq kodiakhq bot merged commit 9c50e11 into acts-project:main Jun 23, 2023
53 of 54 checks passed
@paulgessinger paulgessinger modified the milestones: next, v27.1.0 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants