Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Using UnitConstants in calculation of minHelixRadius in SpacePointGrid #2243

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

LuisFelipeCoelho
Copy link
Member

Same as #2132

@LuisFelipeCoelho LuisFelipeCoelho added the Component - Core Affects the Core module label Jun 26, 2023
@LuisFelipeCoelho LuisFelipeCoelho changed the title fix: Using UnitConstants in calculation of minHelixRadius in SpacePointGrid refactor: Using UnitConstants in calculation of minHelixRadius in SpacePointGrid Jun 26, 2023
@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #2243 (03f510a) into main (360b24f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2243      +/-   ##
==========================================
- Coverage   49.35%   49.35%   -0.01%     
==========================================
  Files         445      445              
  Lines       25263    25264       +1     
  Branches    11650    11650              
==========================================
  Hits        12468    12468              
- Misses       4511     4512       +1     
  Partials     8284     8284              
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SpacePointGrid.ipp 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

📊 Physics performance monitoring for 03f510a

Summary
Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
AMVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

AMVF seeded

AMVF truth_smeared

AMVF truth_estimated

AMVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit b483c1a into acts-project:main Jun 26, 2023
57 checks passed
@paulgessinger paulgessinger modified the milestones: next, v27.1.0 Jul 4, 2023
noemina pushed a commit to noemina/acts that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Seeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants