fix: missing include of array in FpeMonitor.hpp #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarloVarni
added
Bug
📊 Physics performance monitoring for 9ee1d22Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
andiwand
approved these changes
Jun 27, 2023
|
#2248 should catch such issues in the future (at least for |
Codecov Report
@@ Coverage Diff @@
## main #2247 +/- ##
=======================================
Coverage 49.35% 49.35%
=======================================
Files 445 445
Lines 25264 25264
Branches 11650 11650
=======================================
Hits 12468 12468
Misses 4512 4512
Partials 8284 8284 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
noemina
pushed a commit
to noemina/acts
that referenced
this pull request
Jul 5, 2023
I keep finding this kind of compilation issues...
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
This adds a simple script to check all main header files of ACTS for missing includes (like in #2247). This is done very simple: We try to compile (and not link) ```c++ #include <file> int main() { return 0; } ``` If this succeeds, the compiler is able to parse the whole file sucessfully, and thus no include is missing. This check takes about 10 minutes on my machine for the `Core` package... I think that is worth it.
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
This adds a simple script to check all main header files of ACTS for missing includes (like in acts-project#2247). This is done very simple: We try to compile (and not link) ```c++ #include <file> int main() { return 0; } ``` If this succeeds, the compiler is able to parse the whole file sucessfully, and thus no include is missing. This check takes about 10 minutes on my machine for the `Core` package... I think that is worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep finding this kind of compilation issues...