feat: Add ability to mask FPEs from code comment #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syntax is ```cpp float v = 1.0 / 0.0; // MARK: fpeMask(FLTDIV, 1) ```
andiwand
approved these changes
Jul 6, 2023
|
@andiwand You need to handle this manually, to ensure the comment is on the exact line. There are no other smarts applied. |
|
Had to fix the format, can you reapprove @andiwand ? |
andiwand
previously approved these changes
Jul 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
- Coverage 49.27% 49.27% -0.01%
==========================================
Files 450 450
Lines 25410 25415 +5
Branches 11724 11727 +3
==========================================
+ Hits 12521 12523 +2
+ Misses 4556 4554 -2
- Partials 8333 8338 +5 see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for 94cb805Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
github-actions
bot
added
the
Infrastructure
andiwand
approved these changes
Jul 7, 2023
acts-project-service
added
the
Fails Athena tests
CarloVarni
removed
the
Fails Athena tests
paulgessinger
added a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
Syntax is ```cpp float v = 1.0 / 0.0; // MARK: fpeMask(FLTDIV, 1) ``` where you can specify the FPE type, and the maximum number per event that is tolerated. You can add multiple `fpeMask()` expressions per line. NOTE: This will likely only work in case of running from the build directory, not from an installed one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax is
where you can specify the FPE type, and the maximum number per event that is tolerated. You can add multiple
fpeMask()expressions per line.NOTE: This will likely only work in case of running from the build directory, not from an installed one.