refactor: Consistent surface tolerance for propagation #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
📊 Physics performance monitoring for 2032340Summary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
Codecov Report
@@ Coverage Diff @@
## main #2292 +/- ##
==========================================
- Coverage 49.27% 49.27% -0.01%
==========================================
Files 450 450
Lines 25408 25406 -2
Branches 11727 11727
==========================================
- Hits 12521 12519 -2
Misses 4549 4549
Partials 8338 8338
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
asalzburger
approved these changes
Jul 12, 2023
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
…2292) In acts-project#2142 I discovered that the ridders propagator depends highly on the step size taken. At the same time we still use the global static surface tolerance in most of the places which I try to improve here. This allows us to consistently set the surface tolerance for the propagation and to improve the accuracy of the ridders propagator. Includes a bug fix for `AtlasStepper` I discovered after making these changes. The stepper ignored the stepping tolerance in backward mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2142 I discovered that the ridders propagator depends highly on the step size taken. At the same time we still use the global static surface tolerance in most of the places which I try to improve here. This allows us to consistently set the surface tolerance for the propagation and to improve the accuracy of the ridders propagator.
Includes a bug fix for
AtlasStepperI discovered after making these changes. The stepper ignored the stepping tolerance in backward mode.